-
-
Notifications
You must be signed in to change notification settings - Fork 131
Bump SPHT to v0.22 + adopt new syntax for applicable shortcodes #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @stefanv – this should be ready. The CI is failing because the Ubuntu image needs to be updated on the Netlify admin side (the same error we had the other day). |
|
Who has access to numpy.org Netlify? Could you please update the Ubuntu build image to the latest. |
|
Unless I'm looking at the wrong Netlify Project of course. It doesn't look like I have access to the |
|
Okay, I deleted my old "I moved Netlify for numpy.org PR previews over to a separate account that we can all hold the keys to. Currently it is on Gonzalo's personal one. Despite de-authorizing Netlify and re-installing it, it still builds Gonzalo's. I reached out to him via email to disable his numpy.org builds, ..." (after which Gonzalo deleted the other config) I also have an email from Stefan with a GPG-encrypted Netlify key, but we never really used that system and I don't really feel like reverse-engineering it now. So let's just wait for @stefanv to make the change here. |
|
Hah, imagine that. Sorry for the wasted time, Ralf. We have https://github.com/numpy/vault, but I don't think anyone else here uses GPG, so we should find some other place to store it. When researching options for SPEC 6 I found the 1Password community plan: https://github.com/1Password/for-open-source I'm happy to apply for that, if folks think that'd be useful. It may be helpful to write up a document about who has credentials for which services, and what those credentials look like. E.g., what CI tokens do we need on which repos and with what permissions, or who has access to the configuration for various CI services. Anyway, long story short: I updated the build image. |
|
Preview looks good! |
|
Thanks for resolving it Stefan! |
That sounds good to me! I think free-easy-and-secure is what we're looking for, and a community plan like that seems to fit the bill. |
melissawm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked all the pages in the preview in all languages, images show up fine so I think we should merge. Thanks all!

Brief description of what is fixed or changed
This PR bumps the theme to the new v0.22 release, adapting new syntax for figure, image, and button shortcodes via scientific-python/scientific-python-hugo-theme#674. This is building upon @goanpeca's work in #859. Closes #859.